frost-rerandomized: change Randomizer generation #762
+212
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tments and not depend on serialization feature
conradoplg
force-pushed
the
change-randomizer-generation
branch
from
a99ec60 to
ab8e2ef
Compare
natalieesk
reviewed
Jan 15, 2026
frost-rerandomized/src/lib.rs
Outdated
| signing_commitments: &BTreeMap<Identifier<C>, SigningCommitments<C>>, | ||
| ) -> Result<(Self, Vec<u8>), Error<C>> { | ||
| // Generate a dummy scalar to get its encoded size | ||
| let one = <<C::Group as Group>::Field as Field>::zero(); |
Contributor
There was a problem hiding this comment.
Why is this one and not zero?
Contributor
Author
There was a problem hiding this comment.
Good catch. It is wrongly named, I think while writing I meant to actually generate a one (in parallel to the dummy element generation, which should not generate the identity), but a zero is OK for scalars. The same mistake happens elsewhere in the code. I fixed both in dab3f14
…change-randomizer-generation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
- Coverage 77.45% 77.31% -0.15%
==========================================
Files 41 41
Lines 4503 4566 +63
==========================================
+ Hits 3488 3530 +42
- Misses 1015 1036 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to take SigningCommitments and not depend on serialization feature.
This reflects the current state of zcash/zips#895
I created as a draft because it's probably better to wait for that to finish being reviewed and merged.
I ran the tests with
reddsa.